feat(pegboard): expose rivet server from within containers for docker compose by NathanFlurry · Pull Request #2628 · rivet-dev/rivet

NathanFlurry · 2025-06-20T18:55:36Z

Changes

NathanFlurry · 2025-06-20T18:56:10Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-06-20T19:24:45Z

Deploying rivet with Cloudflare Pages

Latest commit:	`eea0c38`
Status:	✅ Deploy successful!
Preview URL:	https://a648c09f.rivet.pages.dev
Branch Preview URL:	https://06-17-feat-pegboard-expose-r.rivet.pages.dev

View logs

graphite-app · 2025-06-20T19:56:55Z

docker/dev-full/rivet-client/entrypoint.sh

+		RIVET_SERVER_HOST="$(dig +short rivet-server)"
+		echo "Adding rule to forward $RIVET_SERVER_IPV4 to rivet-server ($RIVET_SERVER_HOST)"
+		add_ipt_rule "$ipt" "nat" "$NAT_CHAIN" "-d $RIVET_SERVER_IPV4 -j DNAT --to-destination $RIVET_SERVER_HOST"


The DNS lookup for rivet-server lacks error handling. If the lookup fails, RIVET_SERVER_HOST will be empty, resulting in an invalid iptables rule (-j DNAT --to-destination ). Consider adding validation to ensure RIVET_SERVER_HOST contains a valid IP address before creating the rule:

RIVET_SERVER_HOST="$(dig +short rivet-server)" if [ -z "$RIVET_SERVER_HOST" ]; then echo "ERROR: Failed to resolve rivet-server hostname" exit 1 fi echo "Adding rule to forward $RIVET_SERVER_IPV4 to rivet-server ($RIVET_SERVER_HOST)" add_ipt_rule "$ipt" "nat" "$NAT_CHAIN" "-d $RIVET_SERVER_IPV4 -j DNAT --to-destination $RIVET_SERVER_HOST"

This ensures the script fails explicitly rather than creating a broken network configuration.

Suggested change

RIVET_SERVER_HOST="$(dig +short rivet-server)"

echo "Adding rule to forward $RIVET_SERVER_IPV4 to rivet-server ($RIVET_SERVER_HOST)"

add_ipt_rule "$ipt" "nat" "$NAT_CHAIN" "-d $RIVET_SERVER_IPV4 -j DNAT --to-destination $RIVET_SERVER_HOST"

RIVET_SERVER_HOST="$(dig +short rivet-server)"

if [ -z "$RIVET_SERVER_HOST" ]; then

echo "ERROR: Failed to resolve rivet-server hostname"

exit 1

fi

echo "Adding rule to forward $RIVET_SERVER_IPV4 to rivet-server ($RIVET_SERVER_HOST)"

add_ipt_rule "$ipt" "nat" "$NAT_CHAIN" "-d $RIVET_SERVER_IPV4 -j DNAT --to-destination $RIVET_SERVER_HOST"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

cloudflare-workers-and-pages · 2025-06-20T21:37:08Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`eea0c38`
Status:	✅ Deploy successful!
Preview URL:	https://55ee5baf.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://06-17-feat-pegboard-expose-r.rivet-hub-7jb.pages.dev

View logs

cloudflare-workers-and-pages · 2025-06-20T21:37:12Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`eea0c38`
Status:	⚡️ Build in progress...

View logs

… compose

graphite-app · 2025-06-28T01:49:26Z

Merge activity

Jun 28, 1:49 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
Jun 28, 1:50 AM UTC: CI is running for this pull request on a draft pull request (#2662) due to your merge queue CI optimization settings.
Jun 28, 1:51 AM UTC: Merged by the Graphite merge queue via draft PR: #2662.

… compose (#2628)  ## Changes

This was referenced Jun 20, 2025

feat(toolchain): allow passing environment to functions #2624

Closed

chore(pegboard): replace computing image size manually with using tar bytes read #2625

Closed

fix(pegboard): fix hosts file not getting written correctly #2626

Closed

NathanFlurry mentioned this pull request Jun 20, 2025

feat(pegboard): add support for custom host entries #2627

Closed

NathanFlurry force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from 0a32a7f to f56f348 Compare June 20, 2025 19:18

NathanFlurry force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from 046dd3e to 2a7b66a Compare June 20, 2025 19:18

NathanFlurry marked this pull request as ready for review June 20, 2025 19:22

graphite-app bot force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from f56f348 to 7d71cc9 Compare June 20, 2025 19:40

graphite-app bot force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from 2a7b66a to 2b3a103 Compare June 20, 2025 19:40

graphite-app bot reviewed Jun 20, 2025

View reviewed changes

NathanFlurry force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from 2b3a103 to 6fe1578 Compare June 20, 2025 20:34

NathanFlurry force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from 7d71cc9 to 38061b3 Compare June 20, 2025 20:34

NathanFlurry mentioned this pull request Jun 20, 2025

feat: add runners to pb protocol #2433

Closed

MasterPtato mentioned this pull request Jun 20, 2025

fix(workflows): fix branch version bug #2475

Closed

NathanFlurry mentioned this pull request Jun 20, 2025

feat(pb): add runner logs #2447

Closed

MasterPtato mentioned this pull request Jun 20, 2025

chore(pegboard): add exit code log from container runner #2477

Closed

This was referenced Jun 20, 2025

feat(pb): get multi-actors working e2e, add resources for builds #2465

Closed

feat: implement new actor ids #2467

Closed

fix(pb): get new actor ids working e2e #2471

Closed

fix(pegboard): convert ws manager socket to unix socket #2478

Closed

MasterPtato mentioned this pull request Jun 20, 2025

fix: figure out actor log shipping #2622

Closed

This was referenced Jun 20, 2025

fix: get new actors working on docker compose #2623

Closed

chore: fix merge conflicts #2634

Closed

MasterPtato mentioned this pull request Jun 20, 2025

fix: add udp ports to docker compose #2635

Closed

This was referenced Jun 21, 2025

feat: get multi actors working e2e on docker compose #2637

Closed

feat: add actor kv to runners #2638

Closed

MasterPtato mentioned this pull request Jun 25, 2025

feat: add actor queue #2644

Closed

MasterPtato force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from 38061b3 to f07e495 Compare June 26, 2025 01:10

MasterPtato force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from 6fe1578 to 8cc2d55 Compare June 26, 2025 01:10

feat(pegboard): expose rivet server from within containers for docker…

eea0c38

… compose

MasterPtato force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from 8cc2d55 to eea0c38 Compare June 26, 2025 23:20

MasterPtato force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from f07e495 to a130124 Compare June 26, 2025 23:20

MasterPtato mentioned this pull request Jun 27, 2025

fix: fix logs for new actors #2649

Closed

abcxff force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from a130124 to a38bee6 Compare June 27, 2025 19:30

abcxff force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from eea0c38 to 14ceb65 Compare June 27, 2025 19:30

MasterPtato force-pushed the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch from 14ceb65 to eea0c38 Compare June 28, 2025 01:22

MasterPtato force-pushed the 06-17-feat_pegboard_add_support_for_custom_host_entries branch from a38bee6 to a130124 Compare June 28, 2025 01:22

graphite-app bot closed this Jun 28, 2025

graphite-app bot deleted the 06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose branch June 28, 2025 01:51

github-actions bot mentioned this pull request Jun 28, 2025

chore(main): release 25.5.1 #2423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pegboard): expose rivet server from within containers for docker compose#2628

feat(pegboard): expose rivet server from within containers for docker compose#2628
NathanFlurry wants to merge 1 commit into06-17-feat_pegboard_add_support_for_custom_host_entriesfrom
06-17-feat_pegboard_expose_rivet_server_from_within_containers_for_docker_compose

NathanFlurry commented Jun 20, 2025

Uh oh!

NathanFlurry commented Jun 20, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

graphite-app bot Jun 20, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

NathanFlurry commented Jun 20, 2025

Changes

Uh oh!

NathanFlurry commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

graphite-app bot Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

graphite-app bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

NathanFlurry commented Jun 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 20, 2025 •

edited

Loading

graphite-app bot commented Jun 28, 2025 •

edited

Loading